Add logging of remote Eyelink edf filename #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the remote file is needed if an experiment crashes or the EDF fails to transfer.
bartkrekelberg
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lab members have found that they need to know the name of the temp remote edf file after an experiment.
This commit does mean that the original property
edfFilenow stores only the ns formatted name and is empty until a successful transfer happens (previously it held the temp name). InsteadedfFileRemoteholds the temp file name throughout the experiment. This opens a narrow door for a backwards compatibility issue if someone has written code to resurrect failed sessions usingedfFile,but I think that's very unlikely and easily fixed.