Empty designs & matrixIfPossible #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined with a jittered parameter would fail when trying to check the non-existing spcs Fixed by testing for empy spcs and in those cases, simply call the .conditions subasgn for adaptive parameters (given that the design was empty, the adaptive was not "already part of the design")
… pixel offset has to be corect for the vpixx monitor. (In vpixx mode, the xorigin counts from the top left of the vpixx, in generic mode the origin is the origin of the windows coordinate system (so it can be the "other" monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes:
Handle adaptive parameters in empty designs
Allow mixtures of logical and numeric to be combined into an array with parameter.get
This restores behavior of get as it was 3 weeks ago...