yaws_api: Fix ehtml {check, _, number()} attributes

Attribute {check, Key, 10} should expand the same way as {Key, 10}.
erlyaws · Aug 25, 2014 · b513bdd · b513bdd
1 parent cbbbdbe
commit b513bdd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/yaws_api.erl b/src/yaws_api.erl
@@ -1801,7 +1801,7 @@ ehtml_attrs([{check, Name, Value} | Tail]) ->
             true -> $';
             false -> $"
         end,
-    ValueString = [Q,Value,Q],
+    ValueString = [Q,Val,Q],
     [[$ |atom_to_list(Name)], [$=|ValueString]|ehtml_attrs(Tail)].
 
 

diff --git a/test/eunit/ehtml_test.erl b/test/eunit/ehtml_test.erl
@@ -21,6 +21,14 @@ non_void_element_test() ->
     P = "<p></p>",
     P = lists:flatten(yaws_api:ehtml_expand(E)).
 
+attributes_test() ->
+    {ehtml, E} = {ehtml, [{img, [{check, src, "quote\".png"},
+                                 {check, width, 10},
+                                 {height, 20},
+                                 {check, alt, "quote\""}]}]},
+    Img = "<img src='quote\".png' width=\"10\" height=\"20\" alt='quote\"' />",
+    Img = lists:flatten(yaws_api:ehtml_expand(E)).
+
 get_title() ->
     "Funtest Title".