Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the store serialization follows redux recommendations #261

Closed
matmalkowski opened this issue Sep 29, 2020 · 3 comments
Closed

Make sure the store serialization follows redux recommendations #261

matmalkowski opened this issue Sep 29, 2020 · 3 comments
Assignees
@matmalkowski
Labels
enhancement ✨ released on @alpha typescript v2 All issues related to v2
Projects
v2
Milestone
2.0

Comments

@matmalkowski
Copy link
Collaborator

Actually I don't like idea of having this by default baked into the lib - it goes kinda against the redux recommendations itself:

It is highly recommended that you only put plain serializable objects, arrays, and primitives into your store.

I would like to extract this and make it configurable so users when using the middleware can configure it with their own serializer at their own risk (and we ofc can provide them with example serializer used here 👍🏻 )

As a follow up we should address this on v2
@matmalkowski matmalkowski added enhancement ✨ v2 All issues related to v2 typescript labels Sep 29, 2020
@matmalkowski matmalkowski added this to the 2.0 milestone Sep 29, 2020
@matmalkowski matmalkowski added this to To do in v2 via automation Sep 29, 2020
@matmalkowski matmalkowski self-assigned this Oct 23, 2020
@matmalkowski
Copy link
Collaborator Author

I'm going to work on this

@matmalkowski matmalkowski moved this from To do to In progress in v2 Oct 23, 2020
matmalkowski added a commit that referenced this issue Oct 23, 2020
@matmalkowski
fix: remove default custom serialization and make it an opt-in option
20b6cab 
Removing custom serializer as a default, since its not alligned with redux recomendation about store
& serialization

fix #261
@matmalkowski matmalkowski mentioned this issue Oct 23, 2020
Merged
matmalkowski added a commit that referenced this issue Oct 26, 2020
@matmalkowski
fix: remove default custom serialization and make it an opt-in option (…
5238bce 
…#272)

Removing custom serializer as a default, since its not alligned with redux recomendation about store
& serialization

fix #261
@matmalkowski
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matmalkowski
Copy link
Collaborator Author

resolved #272

v2 automation moved this from In progress to Done Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matmalkowski matmalkowski

Labels
enhancement ✨ released on @alpha typescript v2 All issues related to v2
Projects
v2
  
Done
Milestone
2.0
Development

No branches or pull requests
1 participant
@matmalkowski