fix: remove default custom serialization and make it an opt-in option #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing custom serializer as a default, since its not alligned with redux recomendation about store & serialization fix #261
victorhqc
approved these changes
Oct 26, 2020
|
|
||
| async function getRendererState(callback: (state: unknown) => void) { | ||
| async function fetchInitialState( |
| * @param {MainStateSyncEnhancerOptions} options Additional enhancer options | ||
| * @returns StoreEnhancer | ||
| */ | ||
| export const mainStateSyncEnhancer = (options = defaultOptions): StoreEnhancer => ( |
|
🎉 This PR is included in version 2.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing custom serializer as a default, since its not alligned with redux recommendation about store
& serialization
You can still opt-in for some custom functions via options when creating the enhancers.
Renamed the main functions too.
fix #261