Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem getting store hot reloaded #8

Closed
rsaccon opened this issue Oct 23, 2016 · 3 comments
Closed

problem getting store hot reloaded #8

rsaccon opened this issue Oct 23, 2016 · 3 comments

Comments

@rsaccon
Copy link

rsaccon commented Oct 23, 2016

at my app I have implemented my store as in timesheets, but when I change code during development, it does hot reload, but state does not get updated (when using aliased actions). Does this actually work at the timesheets app ?

const rootReducer = getRootReducer(scope);

but next rootReducer is called like this:

store.replaceReducer(require('../reducers'));

@hardchor
Copy link
Contributor

Probably not, that's a good spot!
I've not actually spent much time getting hot reloading working, it's not something I use an awful lot.

timesheets was originally based off https://github.com/chentsulin/electron-react-boilerplate/blob/master/app/store/configureStore.development.js#L36-L40

Does https://github.com/hardchor/timesheets/blob/4ccaf08dee4e1a02850b5bf36e37c537fef7d710/app/shared/store/configureStore.js#L67 actually get hit when you change the store?

@hardchor
Copy link
Contributor

Moved this to hardchor/timesheets#207

@Nantris
Copy link
Contributor

Nantris commented Sep 20, 2019

@hardchor any idea if this can this work with react-hot-loader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants