fix: align enhancer style with standards to wrap the middleware #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmalkowski
approved these changes
Dec 14, 2020
|
🎉 This PR is included in version 2.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my comments in #260. Unfortunately, I was unable to reproduce this using the tests, but in my setup using the
redux-observablepackage I am having several issues. One of which is solved by aligning with the wrapping of middleware as used in the redux library itself. I think for some reason, in my case (some of) my middleware was overwritten by the middleware applied in the enhancer. Either way, my middleware was not properly executing, but after this fix, it is.I did some extensive research but I was unable to find another library using a similar pattern of applying middleware in the enhancer instead of redux itself, so I do not know if this is 100% correct.