use ipcRenderer.sendSync instead of remote.getGlobal #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hanchaa
changed the title
|
@victorhqc Can this be merged and published soon? I know there's version 2, but it's still technically in alpha stage and Electron is already at version 17, 3 versions after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of electron v10, enableRemoteMoudle is set to false by default, and I had to enable it for this library.
And from v12, remote module was deprecated for security reason and it started to show warning message on devTools console.
I found that getInitialStateRenderer is using remote.getGlobal so I substitute ipcRenderer.sendSync to it.