Add OCF decoder hook

[Strech]

Closes #103

I still have some concerns about how I extend existing internal interfaces for OCF (I've added hook to the end of the existing list of arguments), so I'm very open to hear an opinion and adjust the code

[coveralls]

Pull Request Test Coverage Report for Build 616

• 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 610:	0.0%
Covered Lines:	1708
Relevant Lines:	1708

---

💛 - Coveralls

[zmstone]

maybe create a map here, and use maps:merger/2.

[Strech]

Yes, I think for now it should be simplified and not copy-pasted as I did, will change

[Strech]

I've changed proplist to map also in the spectype

[zmstone]

hmm. if we change avro_binary_decoder:decode_stream/4 like this:

@@ -79,9 +79,11 @@ decode_stream(IoData, Type, StoreOrLkupFun) ->
 -spec decode_stream(iodata(), type_or_name(),
                     schema_store() | lkup_fun(), hook()) ->
         {avro:out(), binary()}.
-decode_stream(IoData, Type, StoreOrLkupFun, Hook) ->
-  do_decode(IoData, Type, avro_util:ensure_lkup_fun(StoreOrLkupFun),
-            avro:make_decoder_options([{hook, Hook}])).
+decode_stream(IoData, Type, StoreOrLkupFun, Hook) when is_function(Hook) ->
+  decode_stream(IoData, Type, StoreOrLkupFun,
+                avro:make_decoder_options([{hook, Hook}]));
+decode_stream(IoData, Type, StoreOrLkupFun, Opts) when is_map(Opts) ->
+  do_decode(IoData, Type, avro_util:ensure_lkup_fun(StoreOrLkupFun), Opts).

we should be able to pass Opts down to avro_binary_decoder
otherwise all other map fields (except for hook) provided by the caller are discarded.

[Strech]

we should be able to pass Opts down to avro_binary_decoder
otherwise all other map fields (except for hook) provided by the caller are discarded.

Yes, I thought about the number of options for OCF being too small in comparison to decoder_options from the binary decoder. But I do pass only Hook (not all options), but I think it makes sense to pass all the decoder options because then I can re-use other functions from avro module, like make encoder and so on.

Thanks for the suggestion and let me try it!

[Strech]

@zmstone I adjust the code and in addition, I expand typespec of decode_stream/4 to reflect decoder_options

[zmstone]

this line is too long.

[Strech]

@zmstone All the pointed suggestions/issues were applied

[zmstone]

Great! Ping @mikpe @jesperes for approval & merge.

[mikpe]

The end result looks pretty good, but it's a lot of back and forth in the commits, which I'd rather avoid. Care to squash to a single commit?

[Strech]

@mikpe Sure, I can make a single commit, no problem

UPD: squash done 📦

[Strech]

@mikpe Hola 👋🏼 Can I ask when do you plan to release the next version with these changes?

[mikpe]

@Strech I can push a new tag tomorrow.

[Strech]

@mikpe Awesome! Thanks ❤️

[mikpe]

Updated changelog and tagged 2.9.3.

[Strech]

@mikpe Thanks a lot 🤝 🎉

[Strech]

@mikpe Sorry for the disruption, but I've noticed that the latest version on a https://hex.pm is 2.9.0, may I also ask to publish the 2.9.3 release? It will be super nice 🤗

[mikpe]

2.9.3 should be on hex now.

[Strech]

@mikpe Thanks again, much appreciated! 🚀