Merge pull request #8 from klarna-incubator/remove-deduplication

fix: remove unnecessary deduplication

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@klarna/geofences-reducer",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Reduces overlapping geofences",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/index.ts

@@ -32,21 +32,17 @@ export function reduce (
   if (config) validateConfig(config)
 
   if (geofences.length === 0) return geofences
-
-  const geofencesDeduplicated: Geofence[] = deduplicate(geofences)
 
-  if (geofencesDeduplicated.length === 1) return geofencesDeduplicated
-
-  const geohashes: string[][] = convertToGeohash(geofencesDeduplicated, config.precision)
+  const geohashes: string[][] = convertToGeohash(geofences, config.precision)
 
   const geofencesReduced: Geofence[] = []
   const geofencesReducedIndexes: number[] = []
   const geofencesRemoved: Geofence[] = []
   const geohashesRemoved: string[][] = []
 
   // Find geofences with unique geohashes
-  for (let index = 0; index < geofencesDeduplicated.length; index++) {
-    const geofence: Geofence = geofencesDeduplicated[index]
+  for (let index = 0; index < geofences.length; index++) {
+    const geofence: Geofence = geofences[index]
     const geofenceGeohashes: string[] = geohashes[index]
 
     const geohashesCopy: string[][] = geohashes.slice()
@@ -112,21 +108,6 @@ function validateConfig(config: { precision: number }) {
   }
 }
 
-function deduplicate(geofences: Geofence[]): Geofence[] {
-  return geofences.filter((geofence, index, geofences) => {
-    return index === geofences.findIndex(geofenceFound =>
-      areGeofencesEqual(geofenceFound, geofence)
-    )
-  })
-}
-
-function areGeofencesEqual(subject: Geofence, target: Geofence): boolean {
-  if (subject.latitude !== target.latitude) return false
-  if (subject.longitude !== target.longitude) return false
-  if (subject.radius !== target.radius) return false
-  return true
-}
-
 function convertToGeohash(geofences: Geofence[], precision: number) {
   return geofences.map(geofence =>
     vicinityhash.convert(

tests/geofences.json

@@ -64,6 +64,11 @@
     "longitude": 13.96389,
     "radius": 40000
   },
+  {
+    "latitude": 48.64989,
+    "longitude": 13.96389,
+    "radius": 10000
+  },
   {
     "latitude": 48.32279,
     "longitude": 14.2888,