Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

update guzzle version #5

Closed
wants to merge 2 commits into from
Closed

update guzzle version #5

wants to merge 2 commits into from

Conversation

shivergard
Copy link

Increase guzzle version , so it can be loaded in Laravel 5

@keis keis changed the title ! update guzzle version Nov 8, 2015
@keis
Copy link
Contributor

keis commented Nov 8, 2015

Hi and thanks for the pull request.

I think it looks reasonable so 👍 from me.
ping @JoakimLofgren

@JoakimLofgren
Copy link
Contributor

Could you update the lock file as well?
The tests are still running with 5.x version Guzzle.

And since it seems like Guzzle use semver you could put it as <7 so all 6.x versions are allowed.
E.g. http://semver.mwl.be/#?package=guzzlehttp%2Fguzzle&version=%3E%3D4.2%20%3C7&minimum-stability=stable

Considering how much Guzzle has changed between 5.x and 6.1.. it could be an idea to release this as 3.0. Anyone implicitly relying on Guzzle when using our SDK could get issues.

@bjora857
Copy link

bjora857 commented Oct 31, 2016

Is this going to be merged anytime soon?

@rasmusbe
Copy link

rasmusbe commented Feb 27, 2017

please merge this, its breaking google php api client as well

@rockymontana
Copy link

Any day now... right? 😂

@rasmusbe
Copy link

rasmusbe commented Apr 3, 2017

Klarna is really maintaining their 💩 ...

@rockymontana
Copy link

Yeah... they're really spitting out new releases!
Now their library are breaking our codebase so that we can't upgrade to a current version of guzzle which is really crappy... 😞🙄

@sirn-se
Copy link

sirn-se commented Jul 24, 2017

No, simply increasing version tolerance in composer.json won´t be enough. Guzzle 6.x is not compatible with 4.x/5.x.

Actually running the tests with Guzzle 6.x causes large amount of errors.

@0x20h
Copy link
Contributor

0x20h commented Jan 10, 2018

Closing this one. We are working on support for Guzzle 6 with PR #12, thanks for your support.

@0x20h 0x20h closed this Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants