Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for validateColor and activateScene #6

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

alisdairjsmyth
Copy link
Contributor

Aligned wrapper method with underlying LIFX API for Validate Color which uses GET method and the query string string. Fix for #5

Aligned wrapper method with underlying LIFX API for Validate Color which
uses GET method and the query string string.
@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@90afb55). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   53.01%           
=========================================
  Files             ?        2           
  Lines             ?      166           
  Branches          ?       50           
=========================================
  Hits              ?       88           
  Misses            ?       78           
  Partials          ?        0
Impacted Files Coverage Δ
dist/lifx.js 54.6% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90afb55...ee60ab0. Read the comment docs.

Updated endpoint URL to align with LIFX endpoint
@alisdairjsmyth alisdairjsmyth changed the title Fix for validateColor Fix for validateColor and activateScene Jun 1, 2019
@alisdairjsmyth
Copy link
Contributor Author

Added fix for issue #7

@rspeicher
Copy link

@klarstil Are you still maintaining this project? I'd really appreciate this fix getting merged. Thanks! 💜

@klarstil
Copy link
Owner

klarstil commented Aug 8, 2019

Hey @rspeicher thanks for hitting me up. Indeed, I'm still working on this project. At the moment I'm working on a complete rewrite in TypeScript & adding support for Lifx Stripe and Lifx Title. I'm at work atm and will push my current development branch as a feature branch when I get home, so you can check it out.

I'll also take care of this issue and merge it, so you have the change in place.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants