Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render 'note' if only one note exists #106

Merged
merged 3 commits into from Jan 22, 2019

Conversation

samsawan
Copy link
Contributor

First of all, thanks for this project. I plan on contributing more meaningfully in the future but this is just a quick one off I found.

If you only have one note in the system and you have the bottom display configured to render, you see a minor typo:
screen shot 2018-10-24 at 9 24 29 am

With this fix, the typo is fixed:
screen shot 2018-10-24 at 9 24 13 am

All other variations are also (still) correct:
screen shot 2018-10-24 at 9 27 01 am

screen shot 2018-10-24 at 9 27 35 am

Copy link

@dougmaitelli dougmaitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to simply change to something like:
Done: 3 - Pending: 47 - Notes: 1
?

@klaudiosinani klaudiosinani added the enhancement New feature or request label Jan 22, 2019
@klaudiosinani klaudiosinani self-requested a review January 22, 2019 18:10
Copy link
Owner

@klaudiosinani klaudiosinani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for taking the time to contribute!

@klaudiosinani klaudiosinani merged commit 57b3990 into klaudiosinani:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants