Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple int overflows on 32 bit arches in s2_test.go #163

Closed
rathann opened this issue Sep 27, 2019 · 2 comments · Fixed by #164
Closed

multiple int overflows on 32 bit arches in s2_test.go #163

rathann opened this issue Sep 27, 2019 · 2 comments · Fixed by #164

Comments

@rathann
Copy link

rathann commented Sep 27, 2019

While running tests on Fedora rawhide (32), I get the following test failures:

./s2_test.go:39:4: constant 4294967285 overflows int
./s2_test.go:39:22: constant 4294967295 overflows int
./s2_test.go:40:47: constant 4294967290 overflows int
./s2_test.go:40:65: constant 4294967295 overflows int
./s2_test.go:40:83: constant 4294967295 overflows int
./s2_test.go:41:23: constant 4294967286 overflows int
./s2_test.go:42:23: constant 4294967287 overflows int
./s2_test.go:43:23: constant 4294967288 overflows int
./s2_test.go:44:23: constant 4294967289 overflows int
./s2_test.go:45:23: constant 4294967290 overflows int
./s2_test.go:45:23: too many errors

It looks like similar to #133 .

@rathann
Copy link
Author

rathann commented Sep 27, 2019

and one more:

 github.com/klauspost/compress/zstd [github.com/klauspost/compress/zstd.test]
./encoder_options_test.go:135:6: constant 2147483648 overflows int
FAIL	github.com/klauspost/compress/zstd [build failed]

klauspost added a commit that referenced this issue Sep 27, 2019
@rathann
Copy link
Author

rathann commented Sep 28, 2019

I can confirm that #164 fixes this.

klauspost added a commit that referenced this issue Oct 1, 2019
* Fix 32 bit system test runs

Fixes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant