Convert switch block to if block #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch statements cannot be inlined. If statements can. Reference: golang/go#7655 golang/go#13071 BenchmarkEncodeDigitsSpeed1e4-4 52.22 53.77 1.03x BenchmarkEncodeDigitsSpeed1e5-4 55.01 57.05 1.04x BenchmarkEncodeDigitsSpeed1e6-4 54.36 57.03 1.05x BenchmarkEncodeDigitsDefault1e4-4 20.33 20.38 1.00x BenchmarkEncodeDigitsDefault1e5-4 11.65 11.71 1.01x BenchmarkEncodeDigitsDefault1e6-4 10.68 10.78 1.01x BenchmarkEncodeDigitsCompress1e4-4 20.38 20.77 1.02x BenchmarkEncodeDigitsCompress1e5-4 11.65 11.85 1.02x BenchmarkEncodeDigitsCompress1e6-4 10.76 10.97 1.02x BenchmarkEncodeTwainSpeed1e4-4 46.40 47.77 1.03x BenchmarkEncodeTwainSpeed1e5-4 57.42 59.34 1.03x BenchmarkEncodeTwainSpeed1e6-4 58.72 61.09 1.04x BenchmarkEncodeTwainDefault1e4-4 18.69 18.91 1.01x BenchmarkEncodeTwainDefault1e5-4 11.64 11.85 1.02x BenchmarkEncodeTwainDefault1e6-4 10.87 10.87 1.00x BenchmarkEncodeTwainCompress1e4-4 18.61 18.81 1.01x BenchmarkEncodeTwainCompress1e5-4 10.34 10.50 1.02x BenchmarkEncodeTwainCompress1e6-4 9.58 9.69 1.01x
|
Thanks a lot! |
klauspost
added a commit
that referenced
this pull request
Nov 23, 2015
Convert switch block to if block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch statements cannot be inlined. If statements can. Reference:
golang/go#7655
golang/go#13071