zstd: Add experimental encoder dictionaries #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add encoder dictionary support. Currently uses the dictionary content and literal compression table. The only unused elements are the FSE tables.
|
Fuzz tests still |
``` BenchmarkEncodeAllDict/length-19-level-fastest-dict-1 BenchmarkEncodeAllDict/length-19-level-fastest-dict-1-32 141180 8351 ns/op 2.28 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-19-level-default-dict-1 BenchmarkEncodeAllDict/length-19-level-default-dict-1-32 19639 60085 ns/op 0.32 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-19-level-better-dict-1 BenchmarkEncodeAllDict/length-19-level-better-dict-1-32 5714 196535 ns/op 0.10 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-12131-level-fastest-dict-1 BenchmarkEncodeAllDict/length-12131-level-fastest-dict-1-32 19077 59129 ns/op 205.16 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-12131-level-default-dict-1 BenchmarkEncodeAllDict/length-12131-level-default-dict-1-32 3999 301825 ns/op 40.19 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-12131-level-better-dict-1 BenchmarkEncodeAllDict/length-12131-level-better-dict-1-32 2352 495323 ns/op 24.49 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-210569-level-fastest-dict-1 BenchmarkEncodeAllDict/length-210569-level-fastest-dict-1-32 1052 1115971 ns/op 188.69 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-210569-level-default-dict-1 BenchmarkEncodeAllDict/length-210569-level-default-dict-1-32 673 1763746 ns/op 119.39 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-210569-level-better-dict-1 BenchmarkEncodeAllDict/length-210569-level-better-dict-1-32 423 2820325 ns/op 74.66 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-102605-level-fastest-dict-1 BenchmarkEncodeAllDict/length-102605-level-fastest-dict-1-32 2352 494047 ns/op 207.68 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-102605-level-default-dict-1 BenchmarkEncodeAllDict/length-102605-level-default-dict-1-32 1142 1049912 ns/op 97.73 MB/s 0 B/op 0 allocs/op BenchmarkEncodeAllDict/length-102605-level-better-dict-1 BenchmarkEncodeAllDict/length-102605-level-better-dict-1-32 662 1791540 ns/op 57.27 MB/s 0 B/op 0 allocs/op ```
|
Fuzz tests have been stable for ~12 hours. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add encoder dictionary support.
Currently uses the dictionary content and literal compression table.
The only unused elements are the FSE tables.
Fixes #140