Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: Fix ignored crc #580

Merged
merged 1 commit into from May 6, 2022
Merged

zstd: Fix ignored crc #580

merged 1 commit into from May 6, 2022

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented May 6, 2022

When IgnoreChecksum(true) was used, single threaded decodes would not consume CRC.

Bonus: Remove crc build tag for fuzzing.

@klauspost klauspost force-pushed the fix-missing-crc-consume branch from 8e3eb92 to f04a617 Compare May 6, 2022
When `IgnoreChecksum(true)` was used, single threaded decodes would not consume CRC.

Bonus: Remove crc build tag for fuzzing.
@klauspost klauspost force-pushed the fix-missing-crc-consume branch from f04a617 to 3c12593 Compare May 6, 2022
@klauspost klauspost merged commit 50ba006 into master May 6, 2022
12 checks passed
@klauspost klauspost deleted the fix-missing-crc-consume branch May 6, 2022
@WojciechMula
Copy link
Collaborator

WojciechMula commented May 6, 2022

Oh, sorry for that. :( I'll try to add some unit tests to cover that case.

BTW, we already used this feature and in a real workload not checking CRC gave us 1.25x speedup! (Yeah, at cost of data corruption in case of cosmic ray hit.)

@klauspost
Copy link
Owner Author

klauspost commented May 7, 2022

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants