Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2: Fix absolute forward seeks #633

Merged
merged 2 commits into from Jun 29, 2022
Merged

s2: Fix absolute forward seeks #633

merged 2 commits into from Jun 29, 2022

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Jun 29, 2022

Un-indexed forward seeks does not preserve correct absolute offset when fully skipping blocks.

If stream is seekable, but no index is provided, allow non-random seeking.

Fixes #632

klauspost added 2 commits Jun 29, 2022
Un-indexed forward seeks does not preserve correct absolute offset when fully skipping blocks.

If stream is seekable, but no index is provided, allow non-random seeking.

Fixes #632
@klauspost klauspost merged commit 07a5f92 into master Jun 29, 2022
13 checks passed
@klauspost klauspost deleted the s2-fix-absolute-seeks branch Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2: non Indexed Seek may seek to the wrong offset
1 participant