Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: Disable extended memory copies (amd64) #644

Merged
merged 1 commit into from Jul 17, 2022

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Jul 17, 2022

Using longer memory copies leads to rare, random crashes with fuzz testing.

It is therefore disabled for now.

Using longer memory copies leads to rare, random crashes with fuzz testing.

It is therefore disabled for now.
@klauspost klauspost requested a review from WojciechMula Jul 17, 2022
@klauspost klauspost merged commit 03c136c into master Jul 17, 2022
15 checks passed
@klauspost klauspost deleted the zstd-add-go-fuzz-tests branch Jul 17, 2022
@WojciechMula
Copy link
Collaborator

WojciechMula commented Jul 18, 2022

BTW, do you think it would be easy to overallocate buffers? I mean make sure we have always a few spare bytes to always use the fast copy routine.

@klauspost
Copy link
Owner Author

klauspost commented Jul 18, 2022

@WojciechMula #645 may be the real crash. We don't control all allocs, and if a destination buffer is provided we don't really want to reallocate just to have a few extra bytes.

For now WithLowMem(false) will use faster path most of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants