Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new error ErrInvalidShardSize #243

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Add new error ErrInvalidShardSize #243

merged 2 commits into from
Feb 23, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Feb 23, 2023

Closes #242

klauspost
klauspost requested changes Feb 23, 2023
View reviewed changes
Copy link
Owner

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. But let's make the error more generic, so it can apply to other sizes.

reedsolomon.go Outdated Show resolved Hide resolved
@rootulp rootulp changed the title Add new error when shard size isn't multiple of 64 Add new error ErrInvalidShardSize Feb 23, 2023
@klauspost klauspost merged commit 4e9455c into klauspost:master Feb 23, 2023
@klauspost
Copy link
Owner

@rootulp Thanks for the contribution!

@rootulp rootulp mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider introducing a new error when shard size is not a multiple of 64
2 participants
@rootulp @klauspost