Use AVX2 SIMD assembly instructions in favor of BYTE sequences. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klauspost Hi Klaus, did you have a chance to look at this? |
|
LGTM. I don't have an easy way to test this at the moment, but I assume you have? |
|
Yes, we have tested it and it is equivalent. NB Just FYI, if you sign up for e.g. Google cloud or Azure then you can get a $300 or so credit which will allow you to spin up VMs with proper CPU support. |
dssysolyatin
pushed a commit
to GetObok/reedsolomon
that referenced
this pull request
Jun 20, 2019
…spost#73) * Use AVX2 SIMD assembly instructions in favor of BYTE sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the BYTE sequences and use proper AVX assembly instructions instead.