Add basic validations to identifier setters #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2024 13:20
…prone API calls - Trim whitespace from identifiers - Reject with warning any blank string value for identifiers - Setting identifiers with the fluent setters to the same value as before will not enqueue an API request
evan-masseau
commented
Apr 11, 2024
| @@ -58,3 +58,10 @@ sealed class ProfileKey(name: String) : Keyword(name) { | |||
| else -> name | |||
| } | |||
| } | |||
|
|
|||
| internal val PROFILE_IDENTIFIERS = arrayOf( | |||
There was a problem hiding this comment.
I wanted to put this inside Profile.companionObject but there must be some initialization order issue, because it just came out as an array of nulls.
kennyklaviyo
approved these changes
Apr 11, 2024
| ) | ||
| null | ||
| }?.also { validatedIdentifier -> | ||
| var property by when (propertyKey) { |
There was a problem hiding this comment.
right?? kotlin is cool
sdk/analytics/src/main/java/com/klaviyo/analytics/model/BaseModel.kt
Outdated
Show resolved
Hide resolved
evan-masseau
commented
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a few very basic validations to the setter functions for identifiers. This will cut down on some avoidable API errors and duplicative API calls.
Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets
CHNL-7204