Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a de-dupe mechanism for push notifications #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evan-masseau
Copy link
Contributor

Description

Similar to apns-collapse-id this would allow us to collapse duplicate push notifications on the device itself. In general, we assumed in the past that we'd manage de-duping this purely from the backend, but this would give us extra options, never a bad thing!

Check List

  • Are you changing anything with the public API? NO
  • Are your changes backwards compatible with previous SDK Versions? YES - tag is a nullable arg
  • Have you tested this change on real device? NOPE
  • Have you added unit test coverage for your changes? NOPE
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports? SHOULD!

Changelog / Code Overview

  • Add extension to parse "notification_tag" out of the remote data message payload
  • Use that as the tag for notifications (just like stock FCM)

Test Plan

  • Test this with the sample / test app. Can easily do it with a dummy payload, don't need to update server code to be able to test.

Related Issues/Tickets

CHNL-9595

@evan-masseau evan-masseau marked this pull request as ready for review June 13, 2024 20:07
@evan-masseau evan-masseau requested a review from a team as a code owner June 13, 2024 20:07
Copy link

This PR has not seen any updates in the last 16 days. Without further action this PR will be closed in 14 days. To disable further staleness checks add the evergreen label.

@github-actions github-actions bot added the stale label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants