Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper methods for developers who use a custom workflow to handle notifications #81

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Helper methods for developers who use a custom workflow to handle notifications #81

merged 7 commits into from
Jun 30, 2023

Conversation

evan-masseau
Copy link
Contributor

@evan-masseau evan-masseau commented Jun 23, 2023 •
edited
Loading

Description

Created extension methods as helpers for displaying klaviyo notifications and handling the opened event.

Check List

  • Are you changing anything with the public API? -- No, but this adds extension methods to Intent that devs can acces
  • Are your changes backwards compatible with previous SDK Versions? Yes
  • Have you tested this change on real device? Yes
  • Have you added unit test coverage for your changes? Yes - updated existing coverage
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports? Yes

Changelog / Code Overview

  • extension method to Intent for passing on RemoteMessage data in the intent
  • extension property to identify whether an intent has klaviyo tracking params
  • the opened push event keys internal

Test Plan

  • Tested with flow from prod to confirm notifications still display properly and opens log properly.

Related Issues/Tickets

#78

@evan-masseau evan-masseau requested a review from a team as a code owner June 23, 2023 02:37
@evan-masseau @kennyklaviyo
Update sdk/analytics/src/main/java/com/klaviyo/analytics/Klaviyo.kt
274079c 
Co-authored-by: Kenny Tsui <63658871+kennyklaviyo@users.noreply.github.com>
ajaysubra
ajaysubra previously approved these changes Jun 26, 2023
View reviewed changes
ajaysubra
ajaysubra previously approved these changes Jun 27, 2023
View reviewed changes
@evan-masseau evan-masseau added this to the Release 1.2.0 milestone Jun 30, 2023
@evan-masseau evan-masseau added the enhancement New feature or request label Jun 30, 2023
ajaysubra
ajaysubra previously approved these changes Jun 30, 2023
View reviewed changes
@evan-masseau evan-masseau merged commit 8501d74 into master Jun 30, 2023
2 checks passed
@evan-masseau evan-masseau deleted the feature/custom-notification-display-helpers branch June 30, 2023 21:25
evan-masseau pushed a commit that referenced this pull request Jun 30, 2023
Merge branch 'master' into rel/1.2.0
ddfb250 
* master:
  Helper methods for developers who use a custom workflow to handle notifications (#81)
  Fixed the behavior of external_id (#87)

# Conflicts:
#	versions.gradle
evan-masseau pushed a commit that referenced this pull request Jul 10, 2023
Merge commit '8501d74d023a6a20f421a60b0c3e15e53983f518' into document…
50a5111 
…ation

* commit '8501d74d023a6a20f421a60b0c3e15e53983f518':
  Helper methods for developers who use a custom workflow to handle notifications (#81)
  Fixed the behavior of external_id (#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysubra ajaysubra ajaysubra approved these changes

@kennyklaviyo kennyklaviyo Awaiting requested review from kennyklaviyo

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evan-masseau @kennyklaviyo @ajaysubra