adding code changes to handle infinite loop issue #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, were you able to test it? |
|
@jordanallain was tested by api call [store url]/rest/V1/carts/[quote id] that hangs for quote with coupon and trigger_recollect = 1 before change and doesnt after this change is made |
jordanallain
approved these changes
Sep 8, 2021
| * QuoteIdMask Resource model | ||
| * @codeCoverageIgnore | ||
| */ | ||
| class QuoteIdMask extends AbstractDb |
There was a problem hiding this comment.
FYI The resource models in Magento2 projects are usually located in the Model/ResourceModel/ folder.
It's better to move it eventually to prevent confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pertains to github issue here and implements some of the logic here as its still unreleased code.
It addresses the bug where if a quote with a coupon has
trigger_recollect = 1then any api calls to retrieve the quote will hang forever. Instead of relying on the magento libraries to retrieve the masked quote id, we implement code to retrieve it ourselves from the DB