Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klaviyo user creation #54

Merged
merged 6 commits into from
Jan 23, 2020
Merged

Klaviyo user creation #54

merged 6 commits into from
Jan 23, 2020

Conversation

njparadis
Copy link
Contributor

First pass at streamlining the initial setup process for M2:

  • Added a section to the extension config page to automate the REST user creation process
  • Sensitive fields in the config page are now encrypted and obfuscated in the frontend

@njparadis
Copy link
Contributor Author

Sensitive data updates

Obfuscated private API key:
image

Obfuscated password:
image

Error/success messaging examples

User already exists:
image

Invalid email:
image

Crappy password:
image

Success:
image

Setup/InstallData.php Outdated Show resolved Hide resolved
Copy link
Contributor

@remstone7 remstone7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, some comments

@remstone7
Copy link
Contributor

assuming the deletion process would still be in the rest role section?

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 10, 2020

@njparadis @remstone7
This is actually not an REST user, this is admin user, that has full permissions to the admin.

It should NOT be inside Stores => Configuration due to security reasons.

Also saving admin user credentials isn't secure, even with encrypting, as this password could be decrypted.

Helper/Data.php Outdated Show resolved Hide resolved
Setup/InstallData.php Outdated Show resolved Hide resolved
Co-Authored-By: Rem Stone <remstone7@gmail.com>
Helper/Data.php Outdated Show resolved Hide resolved
Helper/Data.php Outdated Show resolved Hide resolved
Helper/ListOptions.php Outdated Show resolved Hide resolved
Observer/NewsletterSubscribeObserver.php Show resolved Hide resolved
@njparadis njparadis changed the title REST user creation Klaviyo user creation Jan 21, 2020
@njparadis njparadis merged commit cf4478f into master Jan 23, 2020
@njparadis njparadis deleted the 202001_api_user branch January 23, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants