Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Is this project auto generated? #44

Closed
loevgaard opened this issue Mar 30, 2021 · 5 comments
Closed

Is this project auto generated? #44

loevgaard opened this issue Mar 30, 2021 · 5 comments

Comments

@loevgaard
Copy link
Contributor

Is this project auto generated? If not I will add some PRs improving the overall quality and developer experience if that would be okay?

@remstone7
Copy link
Contributor

It's not autogenerated, what changes are you looking to make?

@loevgaard
Copy link
Contributor Author

Lots

  • Make a CI pipeline
  • Use Psalm
  • Up the requirement to PHP 7.4 including the code
  • Add more tests
  • Overall: make it more robust

What do you think? :)

@remstone7
Copy link
Contributor

all of that looks good we'd definitely appreciate it!

For php 7.4, would you be making this the minimum requirement or just expanding to support it?
For the ci, what would you be using?

@loevgaard
Copy link
Contributor Author

Here is a first PR: #45

@remstone7
Copy link
Contributor

okay cool 👍 will review on the pr's, closing this issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants