This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Initialize GitHub actions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remstone7
reviewed
Mar 30, 2021
composer.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.3", | |||
There was a problem hiding this comment.
we still support 5.* with this, so i don't want to make this a requirement
There was a problem hiding this comment.
Would it be an idea to up the PHP requirement in a separate branch, i.e. 3.x?
There was a problem hiding this comment.
Just to elaborate: It could be beneficial for future development that PHP5.6 is supported in a branch, i.e. 2.x and make a decision that the next branch, i.e. 3.x will support >=7.4. It would make the code in 3.x much more robust and it will also entice users of PHP5.6 to upgrade
There was a problem hiding this comment.
yea, that's a good point, we can do a version bump to no longer support 5.6 when more robust typing is added
remstone7
reviewed
Mar 30, 2021
remstone7
reviewed
Mar 30, 2021
remstone7
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will initialize github actions