-
Notifications
You must be signed in to change notification settings - Fork 48
Initialize GitHub actions #45
Initialize GitHub actions #45
Conversation
composer.json
Outdated
@@ -12,6 +12,7 @@ | |||
} | |||
], | |||
"require": { | |||
"php": ">=7.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still support 5.* with this, so i don't want to make this a requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be an idea to up the PHP requirement in a separate branch, i.e. 3.x
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to elaborate: It could be beneficial for future development that PHP5.6 is supported in a branch, i.e. 2.x
and make a decision that the next branch, i.e. 3.x
will support >=7.4
. It would make the code in 3.x
much more robust and it will also entice users of PHP5.6 to upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that's a good point, we can do a version bump to no longer support 5.6 when more robust typing is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great
This PR will initialize github actions