Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom gas price #77

Merged
merged 3 commits into from Mar 11, 2020
Merged

Custom gas price #77

merged 3 commits into from Mar 11, 2020

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR introduces fixes for setting custom gas unit price.

Added another constructor for DefaultGasProvider. The added constructor takes caver as a parameter and sets gasPrice via getGasPrice.

In addition, the create function that takes custom gas price as a parameter has been added to the classes implementing each TransactionTransformer.

In SmartContract class, when creating TransactionTransformer, change gasProvider of gasProvider as parameter.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

close #76

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 self-assigned this Mar 11, 2020
@jimni1222 jimni1222 added the open/reviewing The issue is under review. label Mar 11, 2020
@jimni1222 jimni1222 merged commit 065bb1e into klaytn:dev Mar 11, 2020
@jimni1222 jimni1222 deleted the customGasPrice branch March 11, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open/reviewing The issue is under review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to deploy/execute SmartContract via SmartContract class
2 participants