Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of wallet layer classes #316

Merged
merged 6 commits into from
May 27, 2020

Conversation

jimni1222
Copy link
Contributor

@jimni1222 jimni1222 commented May 26, 2020

Proposed changes

This PR introduces modification of caver-wallet

  • Removed Wallet class and moved KeyringContainer to packages/caver-wallet/index.js (The code didn't change except signWithKey, signWithKeys, signFeePayerWithKey and signFeePayerWithKeys)

  • Chagned signing function(signWithKey, signWithKeys, signFeePayerWithKey and signFeePayerWithKeys) in KeyringContainer to use signing function in Transaction (no more duplicated logic for signging)

  • Changed caver.wallet.generate return type from void to Array<string>

  • Fixed scrypt-shim CI bug. (refer web3@1.2.3 has broken dependencies web3/web3.js#3210 and Fix npm installation error for websocket and scrypt-shim web3/web3.js#3211)

  • Implemented below functions in Keyring

    • generateSingleKey
    • generateMultipleKeys
    • generateRoleBasedKeys

After this PR caver-js v1.5.0-rc.1 will be released.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

refer #249
close #317

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 self-assigned this May 26, 2020
@jimni1222 jimni1222 merged commit 2e802c2 into klaytn:dev May 27, 2020
@jimni1222 jimni1222 deleted the keyringContainer branch May 27, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'scrypt-shim'
3 participants