This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Backport HttpProvider changes from web3.js to fix handling server-side errors #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
|
|
Working as intended I think |
jimni1222
reviewed
Jul 8, 2022
jimni1222
reviewed
Jul 8, 2022
types/packages/caver-core-requestmanager/caver-providers-http/src/index.d.ts
Show resolved
Hide resolved
|
@nazarhussain Hi, Nazarhussain. Could you sign CLA to merge this PR? |
ghost
mentioned this pull request
|
@jimni1222 Since he is the maintainer of the web3.js project, I could reset the git author if necessary. |
|
@ayanamidev Could you please reset the git author then? Because of that commit, i cannot merge this. |
web3-providers-http: Migrate from xhr2-cookies to cross-fetch (#5179) * web3-providers-http: Migrate from xhr2-cookies to cross-fetch (#5085) * Update CHANGELOG.md * Migrate from xhr2-cookies to cross-fetch * Address comments for web3-providers-http * web3-providers-http: Prevent global leakage of this.connected * Return server side error without creating additional error object * Fixed type of http.Agent https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export * Removed unused variable * Remove unnecessary catch block * Remove unnecessary internal _prepareRequest function from web3-providers-http * ⬆️ Update package-lock.json * Update packages/web3-providers-http/src/index.js Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> * ⚰️ Remove dead code * 🎨 Improve the with credentials check
|
@jimni1222 Done. |
jimni1222
approved these changes
Jul 8, 2022
|
@jimni1222 I had signed the CLA, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #637
Backported changes from PR web3/web3.js#5085 web3/web3.js#5179 to fix handling server-side errors that return timeouts, rate limits ( 429 ), etc.