Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIP-3 Klaytn Keystore Format v4 #3

Merged
merged 8 commits into from
Jan 30, 2020
Merged

KIP-3 Klaytn Keystore Format v4 #3

merged 8 commits into from
Jan 30, 2020

Conversation

kjhman21
Copy link
Collaborator

@kjhman21 kjhman21 commented Jan 9, 2020

When opening a pull request to submit a new KIP, please use the suggested template: https://github.com/klaytn/KIPs/blob/master/kip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your Github username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@kjhman21 kjhman21 self-assigned this Jan 9, 2020
aidan-kwon
aidan-kwon reviewed Jan 9, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon reviewed Jan 9, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 9, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 9, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
@kjhman21 kjhman21 requested a review from nogang January 15, 2020 23:14
kjhman21 and others added 2 commits January 16, 2020 08:15
@kjhman21 @aidan-kwon
Update KIPs/kip-2.md
8902888 
Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>
@kjhman21
Reformat examples of v4 keys
6a36e85
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
jimni1222
jimni1222 reviewed Jan 15, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
@kjhman21
update single quote to double quote
4ff0e2a 
Also mismatched format is fixed
jimni1222
jimni1222 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@jimni1222 jimni1222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thank you for changing!

@kjhman21 kjhman21 changed the title Introduce KIP-2: Klaytn Keystore Format v4 [Proposal] Klaytn Keystore Format v4 Jan 16, 2020
aidan-kwon
aidan-kwon reviewed Jan 17, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon reviewed Jan 17, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon reviewed Jan 17, 2020
View reviewed changes
KIPs/kip-2.md Outdated Show resolved Hide resolved
aidan-kwon
aidan-kwon approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor things

@kjhman21 @aidan-kwon
Apply suggestions from code review
9a8d3fd 
Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>
This was referenced Jan 29, 2020
Closed
Merged
@kjhman21 kjhman21 added the KIP assigned KIP number is assgined label Jan 29, 2020
@kjhman21 kjhman21 mentioned this pull request Jan 29, 2020
Merged
9 tasks
This was referenced Jan 29, 2020
Merged
Merged
@kjhman21 kjhman21 changed the title [Proposal] Klaytn Keystore Format v4 KIP-3 Klaytn Keystore Format v4 Jan 30, 2020
@kjhman21 kjhman21 merged commit 8658f9d into klaytn:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimKyungup KimKyungup KimKyungup approved these changes

@jimni1222 jimni1222 jimni1222 approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@joowon-byun joowon-byun Awaiting requested review from joowon-byun

@smseo smseo Awaiting requested review from smseo

@nogang nogang Awaiting requested review from nogang

Assignees

@kjhman21 kjhman21

Labels
KIP assigned KIP number is assgined Proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kjhman21 @KimKyungup @jimni1222 @aidan-kwon