Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system contracts KIP-81, 103, 113, 149 #29

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Add system contracts KIP-81, 103, 113, 149 #29

merged 10 commits into from
Mar 8, 2024

Conversation

ian0371
Copy link

@ian0371 ian0371 commented Feb 22, 2024

Proposed changes

This PR adds Klaytn system contracts KIP-81, 103, 113, 149 + audit reports.

Due to linter fail, I had to add .solhintignore and add .prettierignore. They ignore the protocol directory, as it must match the audit report.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or Enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA by posting "I have read the CLA Document and I hereby sign the CLA" in the comment
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you proposed and what alternatives you have considered, etc.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Feb 22, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ian0371
Copy link
Author

ian0371 commented Feb 22, 2024

I have read the CLA Document and I hereby sign the CLA

This should only affect the contracts in contracts/KIP/protocol.
When `solhint` implements the override feature in its config, this shall be fixed.
@ian0371 ian0371 requested review from JayChoi1736, praveen-klaytn and modiashwani and removed request for modiashwani March 8, 2024 02:10
@ian0371 ian0371 merged commit f54fb80 into main Mar 8, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants