Feat/celer #16
Feat/celer #16
Conversation
| } | ||
|
|
||
| }) | ||
|
|
||
| it("should perform mintCanonicalToken action", async () => { |
There was a problem hiding this comment.
isn't burnCanonical Token ?
There was a problem hiding this comment.
Also why is the expect condition checking for invalid deposit id ?
There was a problem hiding this comment.
this invalid burn id isn't expect is expecting to be true. This error message I've just wrote (for expect) to return if burnId doesn't contains 0x (which can only be case when burnCanonicalToken wasn't successful).
| @@ -55,4 +99,6 @@ describe("poolTransfer", async () => { | |||
|
|
|||
| expect(transferId).to.contains('0x', "invalid transfer id") | |||
There was a problem hiding this comment.
why invalid transfer id for success poolTransfer ?
There was a problem hiding this comment.
this invalid transfer id isn't expect is expecting to be true. This error message I've just wrote (for expect) to return if transferId doesn't contains 0x (which can only be case when poolTransfer wasn't successful).
| }) | ||
| it("should throw error if DEPOSIT_ID is of status 'TRANSFER_ALREADY_COMPLETED'", async function() { | ||
| let alreadyRefundedDepositId = '0x0963539b3ef3f0c4033e3e93ac733a7f6484345f6db8d3d85b389033ab466827' | ||
| return true; |
There was a problem hiding this comment.
why are we returning here ?
There was a problem hiding this comment.
sorry, did it while local testing. forgot to remove. Removed now
packages/bridges-starter-kit/celer/test/burnCanonicalTokenRefund-test.ts
Show resolved
Hide resolved
Proposed changes
This PR includes the unit test cases for Celer Bridge module
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.