Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Bug/readmeupdates #20

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Bug/readmeupdates #20

merged 13 commits into from
Feb 8, 2023

Conversation

praveen-kaia
Copy link
Contributor

Proposed changes

  • Modified Oracle pricefeed and randomnumber to pass variables.
  • Fixed lint issues
  • Done package renaming based on the discussion.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or Enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA by posting "I have read the CLA Document and I hereby sign the CLA" in the comment
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@0xxlegolas 0xxlegolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to init via cli

@praveen-kaia
Copy link
Contributor Author

Refactor to init via cli

Modifed as part of latest changes. Added a new package kds-cli which contains oracle dependency and sets up the oracle hardhat project.

@0xxlegolas 0xxlegolas merged commit 7997ca1 into main Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants