fix governance getReward unit test

klaytn · May 16, 2024 · 4edd49e · 4edd49e
1 parent fa6ed2e
commit 4edd49e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/governance/api.go b/governance/api.go
@@ -91,7 +91,11 @@ func (api *GovernanceKaiaAPI) GetRewards(num *rpc.BlockNumber) (*reward.RewardSp
 	}
 
 	header := api.chain.GetHeaderByNumber(blockNumber)
-	txs, receipts := api.chain.GetBlock(header.Hash(), blockNumber).Transactions(), api.chain.GetReceiptsByBlockHash(header.Hash())
+	block := api.chain.GetBlock(header.Hash(), blockNumber)
+	if block == nil {
+		return nil, errors.New("not found block")
+	}
+	txs, receipts := block.Transactions(), api.chain.GetReceiptsByBlockHash(header.Hash())
 	if header == nil {
 		return nil, fmt.Errorf("the block does not exist (block number: %d)", blockNumber)
 	}

diff --git a/governance/api_test.go b/governance/api_test.go
@@ -291,10 +291,15 @@ func (bc *testBlockChain) GetHeaderByNumber(val uint64) *types.Header {
 }
 
 func (bc *testBlockChain) GetReceiptsByBlockHash(hash common.Hash) types.Receipts {
-	return nil
+	return types.Receipts{
+		&types.Receipt{GasUsed: 10},
+		&types.Receipt{GasUsed: 10},
+	}
 }
 
-func (bc *testBlockChain) GetBlockByNumber(num uint64) *types.Block         { return nil }
+func (bc *testBlockChain) GetBlockByNumber(num uint64) *types.Block {
+	return types.NewBlockWithHeader(bc.GetHeaderByNumber(num))
+}
 func (bc *testBlockChain) StateAt(root common.Hash) (*state.StateDB, error) { return nil, nil }
 func (bc *testBlockChain) State() (*state.StateDB, error)                   { return nil, nil }
 func (bc *testBlockChain) Config() *params.ChainConfig {

diff --git a/node/cn/gasprice/gasprice_test.go b/node/cn/gasprice/gasprice_test.go
@@ -102,7 +102,7 @@ func newTestBackend(t *testing.T, magmaBlock, kaiaBlock *big.Int) (*testBackend,
 	config.KoreCompatibleBlock = kaiaBlock
 	config.ShanghaiCompatibleBlock = kaiaBlock
 	config.CancunCompatibleBlock = kaiaBlock
-	config.KaiaCompatibleBlock = kaiaBlock
+	// config.KaiaCompatibleBlock = kaiaBlock
 	config.Governance = params.GetDefaultGovernanceConfig()
 	config.Istanbul = params.GetDefaultIstanbulConfig()
 	blocks, _ := blockchain.GenerateChain(gspec.Config, genesis, gxhash.NewFaker(), db, testHead+1, func(i int, b *blockchain.BlockGen) {