Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update label #1

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Update label #1

merged 1 commit into from
Jun 27, 2019

Conversation

kjhman21
Copy link
Collaborator

Proposed changes

  • Update label strings to match label strings in this repo.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@kjhman21 kjhman21 requested a review from smseo June 27, 2019 01:51
@kjhman21 kjhman21 self-assigned this Jun 27, 2019
smseo
smseo approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@smseo smseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smseo smseo requested a review from bitaholic June 27, 2019 02:43
@kjhman21 kjhman21 merged commit df5b90a into klaytn:master Jun 27, 2019
@kjhman21 kjhman21 deleted the updateLabel branch June 27, 2019 02:53
jeongkyun-oh referenced this pull request in jeongkyun-oh/klaytn Jun 27, 2019
@KimKyungup
SC : Reflected HAECHI LABS audit #1 (#3246)
3aa4163 
* Fixed audit issues

- bug fix of bridge contract check
- remove unnecessary mint code
- remove unnecessary function
- add revert code if value is zero in charge code.

* refleceted review.

* refleceted review.

* revert requrie code
KimKyungup referenced this pull request in KimKyungup/klaytn Jul 31, 2019
@KimKyungup
review #1-1
b9719db
KimKyungup referenced this pull request in KimKyungup/klaytn Jul 31, 2019
@KimKyungup
review #1-1
0af0300
KimKyungup added a commit that referenced this pull request Jul 31, 2019
@KimKyungup
Service chain RC1 (#104)
3a371fd 
* SC : Refine bridge/token contract (#19)

* Refactor token contract for service chain

* Refactoring bridge/token contract

- token/nft -> ERC20/721
- base token contract
- remove unnecessary return value

* go generate nft.go

* refactor duplicated code

* SC : Support value transfer fee for KLAY/ERC20 (#23)

* Support KLAY/ERC20 tranfser with fee

* fee comsuption during request and add unit test

* Add wrong fee unit test

* revert unnecessary change

* reflected review

* fixed typo

* fixed typo

* reflect revie

* Replace smseo with kjhman21 in CODEOWNERS (#26)

Since smseo would not be able to actively participate in code reviews
for a while, it would be better to remove him from CODEOWNERS.

* SC: fix stopping bridge recoveries for shutdown (#22)

* SC: mitigate a scn shutdown problem (#25)

*  SC: add kspn and ksen binary support (#21)

* SC: add kspn and ksen binary support

* SC: fix command option handling

* SC: apply review comments

* SC: remove network configuration for service chain

* SC: remove baobab and cypress options from kspn and ksen

* SC: try rebuild

* SC: try rebuild

* Update cmd/ksen/doc.go

Co-Authored-By: Sangmin Seo (Sam) <sam.seo@groundx.xyz>

* Update build/rpm/main.go

Co-Authored-By: Sangmin Seo (Sam) <sam.seo@groundx.xyz>

* Update cmd/ksen/main.go

Co-Authored-By: Sangmin Seo (Sam) <sam.seo@groundx.xyz>

* Update cmd/kspn/doc.go

Co-Authored-By: Sangmin Seo (Sam) <sam.seo@groundx.xyz>

* Update cmd/kspn/main.go

Co-Authored-By: Sangmin Seo (Sam) <sam.seo@groundx.xyz>

* apply review comments for converting node types

* SC : Add value transfer Fee APIs (#29)

* Add SC Fee APIs

* add missed web3ext for new api

* SC: add subbridge support for ksen (#30)

* Added Service Chain Network on homi docker compose (#20)

* Added Service Chain Network on homi docker compose

- service chain network is added on docker compose

* Renamed serviceGenesis to scGenesis

* Change code owners (#28)

* SC: fix a mainbridge port mapping of docker compose (#34)

* SC: remove an address book from the sc genesis in homi (#36)

* SC: remove an address book from the sc genesis in homi

* SC: update homi docker compose for kspn and ksen (#35)

* SC: update homi docker compose for kspn and ksen

* SC: change the docker image name

* Update names

* Apply review comments

* SC: change the max peer of the main and sub bridges to one (#37)

* SC: change the max peer of the main and sub bridge to one

* remove deadcode

* apply review comments

* Revert "Prevent voting except add, remove validator (#3565)" (#31)

* [Reward] stakingInfo (#32)

make reward package under klaytn directory
copy stakingInfo from contracts/reward/reward.go to reward/stakingInfo.go
make governanceHelper interface
unused function string() from stakingInfo is not copied

* Add test code for checking generated hashes are equal to that of baobab and cypress (#41)

* SC: update parent receipt API for more information as RPC output (#33)

* Update parent receipt API for more information as RPC output

* reflected review

* review reflected

* Add nil checks for the wrong genesis configuration (#40)

* Add nil checks for the wrong genesis configuration

* Apply a review comment

* fix ci test fail (#44)

* increase delay time

* change default shell to bash

* remove unsuse testscript

* Add a godoc badge with descriptions (#48)

* account: add optional block number for contract calls (#46)

* account: add optional block number for calls

* Apply a review comment

* [Reward] Staking info cache (#42)

copy stakingInfoCache from contract/reward/reward.go to reward/stakingInfoCache.go
copy test code from reward_test.go to stakingInfoCache_test.go

* change log level (#52)

* Fix a readme for kspn (#51)

* SC: Support FeeLimit of value transferring. (#38)

* Support FeeLimit

* reflect of Aidan's review.

* reflect review

- modifiy RequestKLAYTransfer parameter
FeeLimit -> Amount
- prevent to usless KLAY/ERC transfer to refund zero value.

* fix argument type

* fix typo

* remove zero transfer check

* reflected review

* reflect review

* simplify code

* [Reward] rewardConfigCache (#47)

add rewardConfigCache and test code

* Update doc.go for governance package (#45)

* Update doc.go for governance package

* SC : Refactor Request/Handle event structure (#54)

* refactor event

* clean code

* clean code2

* reflected review

* reflect review

* Changed GovernanceVotes GovernanceTallies and GovernanceSet (#43)

* [Reward] AddressBookManager (#53)

Add addressBookManager and test code

* [reward] doc.go (#50)

update reward/doc.go

* Update doc.go of package downloader (#62)

* write doc

* Update datasync/downloader/doc.go

Co-Authored-By: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>

* Apply suggestions from code review

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>
Co-Authored-By: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>

* Apply suggestions from code review

* Apply suggestions from code review

Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>
Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>

* SC : Add extended bridge contract / callback contract example (#57)

* Service chain callBack example

* go fmt

* reflect review

* rebase branch and go generate caused by contract code changed

* reflect suggestions

* update reward/doc.go (#69)

update reward/doc.go

* Add description of doc.go for common/hexutil (#67)

* Add more description for common/hexutil package on doc.go
Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Fix typo and refine a sentence in README.md (#65)


Signed-off-by: Hyung-Kyu Choi <hqueue.choi@groundx.xyz>

* [Reward] Staking manager (#60)

add stakingManager and test code.

* database: updated doc.go (#71)

* database: updated doc.go

* Fixed gofmt failure

* Reflected review comments

* Apply suggestions from code review

Co-Authored-By: Rick <rick.no@groundx.xyz>

* SC : Refactor bridge contract method parameter (#59)

* refactor contract method parameter

* reflect review

* reflect review

* Add more description for common/profile package (#75)

* Add descriptions on doc.go for common/compiler package (#64)

* Add descriptions on doc.go for common/compiler package
Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>

* Apply review feedbacks (#70)

* Update doc.go of package account (#56)

* Update doc.go of package account

* Remove line

* Reflect review

* Add period

* Edit mistypo

* Update blockchain/types/account/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* Update blockchain/types/account/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* fmt

* Make governance variables to be atomic (#61)

* Add missing atomic operation for lastGovernanceStateBlock
Make nodeAddress as an atomic.Value
Add idxCacheLock to protect idxCache

* Update doc.go of package fetcher  (#68)

* update doc

* Apply suggestions from code review

Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Apply suggestions from code review

Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Jasmine <32922423+jimni1222@users.noreply.github.com>

* Add more description for common/math package (#72)

* Add more description for common/math package

Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

Co-Authored-By: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>

* [Reward] Reward Distributor (#74)

add RewardDistributor and test code.

* Change the issue report location from Ethereum to Klaytn (#85)

* [Reward] Addressbook connector (#86)

* change addressBookManager to addressBookConnector
* change testcode

* change file names to snake_case (#87)

this pr changes names of files in reward package to snake_case

* SC: Support keystore files for bridge accounts (#77)

* support keystore for bridge accounts

* reflect review @aidan @jasmine

* reflect review 2nd

* remove unnecessary flag test case

* reflect review #3

* fix typo

* review #4

* review #5

* go fmt

* remove unnecessary.

* review 6

* Update blockchain/types/accountkey/doc.go (#55)

* Update blockchain/types/accountkey/doc.go

* Modify form

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Add period

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* Reflect review

* Add fail key description

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Jeongho Albert Nah <jeongho.nah@gmail.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

* Update blockchain/types/accountkey/doc.go

* Update blockchain/types/accountkey/doc.go

* Update blockchain/types/accountkey/doc.go

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Update blockchain/types/accountkey/doc.go

* fmt

* [doc] update fork/doc.go (#91)

update fork/doc.go

* state: updated blockchain/state/doc.go (#81)

* Updated blockchain/state/doc.go

* Fixed gofmt failure

* Reflected review comments

* Reflected review comments

* Reflected review comments

* Fixed for godoc

* Update blockchain/state/doc.go

Co-Authored-By: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>

* Add more description for web3ext.go (#89)

* Add more description for web3ext.go

* Update console/web3ext/doc.go

Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Add more expression on doc.go for bitutil package (#63)

* Add more expression on doc.go for bitutil package

* Update common/bitutil/doc.go

Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Refactor voteMap to avoid data race (#83)

* Refactor voteMap to avoid data race

* Apply feedbacks

* statedb: updated storage/statedb/doc.go (#82)

* statedb: updated storage/statedb/doc.go

* Reflected review comments

* SecureTire -> SecureTrie

* Changed to meet the requirements of godoc formatting

* Read-and-Write-actualGovernanceBlock-atomically (#92)

* Add more description on doc.go for common/fdlimt package (#66)

* Add more description on doc.go for common/fdlimt package
Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Merge duplicated function GetLatestGovernanceItem and GetGovernanceValue (#94)

* Merge-duplicated-function-GetLatestGovernanceItem
* Remove GetLatestGovernanceItem()

* Add more description for common/mclock package (#73)

* Add more description for common/mclock package
Co-Authored-By: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>
Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>

* Add more description on doc.go of the `common` package (#88)

* Add more description on doc.go of the `common` package
Co-Authored-By: Melvin Junhee Woo <melvin.woo@groundx.xyz>
Co-Authored-By: Kuwon Sebastian Ra <kwla103@naver.com>

* SC: add a multi-bridge and multi-sig support (#79)

* change default consensus of SC to istanbul (#99)

* SC: Added handledRequestValueTransfer<hash, isDone> map into bridge contract. (#78)

* Add RTX Hash into handleValueTransfer

* Added TCs to check the feature

* update handledRequests as an base contract.

* review

* review

* reflect review #3

* homi support to generate keystore

* review#1

* review #1-1

* review#1-2

* review#1-3 @aidan

* review#1-4 @melvin
KimKyungup added a commit that referenced this pull request Aug 1, 2019
@KimKyungup
[dev] SC : Make homi to generate testkey's keystore file (#106)
420d542 
* homi support to generate keystore

* review#1

* review #1-1

* review#1-2

* review#1-3 @aidan

* review#1-4 @melvin
KimKyungup added a commit that referenced this pull request Aug 1, 2019
@KimKyungup
SC : Make homi to generate testkey's keystore file (#98)
ccc3aa9 
* homi support to generate keystore

* review#1

* review #1-1

* review#1-2

* review#1-3 @aidan

* review#1-4 @melvin
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 2, 2019
@KimKyungup
reflect review #1
849038d
KimKyungup added a commit that referenced this pull request Aug 2, 2019
@KimKyungup
reflect review #1
18d2e98
KimKyungup added a commit that referenced this pull request Aug 5, 2019
@KimKyungup
SC: Add msg.sender as an operator and minor refactoring (#105)
f4b8a9e 
* Add msg.sender as an operator and minor refactoring

* reflect review #1
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 5, 2019
@KimKyungup
review #1
908a729
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 5, 2019
@KimKyungup
review #1
4b97099
KimKyungup added a commit that referenced this pull request Aug 5, 2019
@KimKyungup
SC: ExtraData is added into request/handle method. (#117)
40cfdfb 
* Add extraData on request/handle method

* review #1

* review #2

* review #3
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 6, 2019
@KimKyungup
review #1
5d41d82
KimKyungup added a commit that referenced this pull request Aug 8, 2019
@KimKyungup
SC: Inheritance structure for bridge contract (#126)
787a43d 
* inheritance structure for bridge contract

* review #1

* review#2

* review#3

* review#4

* Review #Last @Ethan Hope

* reflect solidity lint tool

* review #6

* review #7
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 9, 2019
@KimKyungup
review #1
374fda3
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 9, 2019
@KimKyungup
review #1
6a6dcb8
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 9, 2019
@KimKyungup
review #1-2
8a9c003
KimKyungup added a commit that referenced this pull request Aug 12, 2019
@KimKyungup
SC: Add APIs for lock/unlock bridge operators (#143)
84497bb 
* Add APIs for lock/unlock bridge operators

* review #1

* review #1

* review#1-1

* review #1-2

* review#2

* review#3
KimKyungup referenced this pull request in KimKyungup/klaytn Aug 13, 2019
@KimKyungup
review #1
9f549c1
KimKyungup added a commit that referenced this pull request Aug 14, 2019
@KimKyungup
SC: Support a non-echo prompt for subbridge operator unlock API. (#150)
2807622 
* Support prompt for subbridge operator unlock API.

* review #1
@nogang nogang mentioned this pull request Nov 22, 2019
Merged
9 tasks
jeongkyun-oh added a commit that referenced this pull request Mar 30, 2021
@jeongkyun-oh
Merge pull request #1 from aidan-kwon/jk/210319-govComment
5f5f2d8 
Add comments for some governance methods
@manbobo2002 manbobo2002 mentioned this pull request Nov 15, 2021
Closed
@manbobo2002 manbobo2002 mentioned this pull request Nov 25, 2021
Closed
joowon-byun added a commit to joowon-byun/klaytn that referenced this pull request Jan 5, 2022
@joowon-byun
Merge pull request klaytn#1 from winnie-byun/payments
b95e7cb 
Contract for Payment
@jimni1222 jimni1222 mentioned this pull request Jul 4, 2022
Merged
9 tasks
@gitmewai gitmewai mentioned this pull request Jul 28, 2022
Closed
@yoomee1313 yoomee1313 mentioned this pull request Nov 8, 2022
Closed
ehnuje added a commit to ehnuje/klaytn that referenced this pull request May 8, 2023
@ehnuje
all: mint and burn of native token (klaytn#1)
4be1ee6 
* contracts, vm: mint and burn native token

- able to mint/burn (a256b35c)
- payments (c07215e0)
- update value of code in geneis.json (59ea6fda)
- update Payment.sol (ac2b7302)
- removed unnecessary data (819cda80)
- changed permission contract address (f010236b, 8e4fe38d, 808c3903)

* homi: added flag to gen openassetchain's genesis

- `--openassetchain-test` is added to gen openassetchain's genesis
- when it is given, 0 gas price, 0 minting amount and mint-burn feature
- and its access control contract is deployed
blukat29 added a commit to blukat29/klaytn that referenced this pull request Apr 1, 2024
@blukat29
Merge pull request klaytn#1 from klaytn/fix/go1.22
92a9591 
Upgrade to go1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitaholic bitaholic bitaholic approved these changes

@smseo smseo smseo approved these changes

Assignees

@kjhman21 kjhman21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjhman21 @bitaholic @smseo