Read minimum staking value from database #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
force-pushed
the
KLT-1026-fix-global-minimum-stake
branch
from
387d2d3
to
6011acb
Compare
jeongkyun-oh
requested review from
aidan-kwon,
hyochan-brown,
KimKyungup,
joowon-byun and
yoomee1313
as code owners
ehnuje
reviewed
Aug 20, 2021
jeongkyun-oh
force-pushed
the
KLT-1026-fix-global-minimum-stake
branch
from
887c539
to
27395af
Compare
ehnuje
previously approved these changes
Aug 20, 2021
hqjang-pepper
previously approved these changes
Sep 2, 2021
jeongkyun-oh
dismissed stale reviews from hqjang-pepper and ehnuje
via
b02ab8d
jeongkyun-oh
force-pushed
the
KLT-1026-fix-global-minimum-stake
branch
from
27395af
to
b02ab8d
Compare
aidan-kwon
reviewed
Sep 10, 2021
jeongkyun-oh
force-pushed
the
KLT-1026-fix-global-minimum-stake
branch
from
e73a7c9
to
b0b356f
Compare
Comment on lines
+83
to
+84
| config := *params.TestChainConfig // copy test chain config which may be modified | ||
| genesis.Config = &config |
There was a problem hiding this comment.
It seems good to import chainconfig like this way in case the chainconfig changes later. LGTM
hqjang-pepper
previously approved these changes
Sep 10, 2021
yoomee1313
previously approved these changes
Sep 10, 2021
jeongkyun-oh
dismissed stale reviews from yoomee1313 and hqjang-pepper
via
3db9b4a
jeongkyun-oh
force-pushed
the
KLT-1026-fix-global-minimum-stake
branch
from
3db9b4a
to
5fa7ba5
Compare
yoomee1313
approved these changes
Sep 10, 2021
hqjang-pepper
approved these changes
Sep 13, 2021
aidan-kwon
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)