Updated checkVote logic for demoted #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
changed the title
jeongkyun-oh
force-pushed
the
KLT-1027-fix-checkvote-logic
branch
from
05c89da
to
65608e4
Compare
jeongkyun-oh
force-pushed
the
KLT-1027-fix-checkvote-logic
branch
from
65608e4
to
c0199ce
Compare
jeongkyun-oh
requested review from
aidan-kwon,
hyochan-brown,
KimKyungup and
yoomee1313
as code owners
ehnuje
approved these changes
Aug 18, 2021
hqjang-pepper
approved these changes
Aug 30, 2021
|
@aidan-kwon @hyochan-brown @KimKyungup Please let me know if you have any suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing demoted validator does not work properly. This is because the vote is considered as invalid in
checkVotemethod. This PR fixes thecheckVotelogic to consider demoted validator as well.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)