Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the request body size limit of fastHttpServer with maxRequestContentlength #1029

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

aidan-kwon
Copy link
Member

Proposed changes

maxRequestContentlength option validates the request body size of API requests.
However, the option is not used to limit the request body size of fastHttp server.
Without the change, fastHttp server has defaultMaxRequestBodySize, 4MB.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@hqjang-pepper hqjang-pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aidan-kwon aidan-kwon merged commit 8283b58 into klaytn:dev Sep 9, 2021
@aidan-kwon aidan-kwon deleted the 210823-fastHttpReqBodyLimit branch September 9, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants