blockchain/vm: modify opcode computation costs for istanbulCompatible change #1033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some opcode computation costs are modified and it is activated with istanbulCompatible change activation.
sload
,balance
,extcodehash
. It is the revert of the computation cost modification which is applied at blockchain/vm: add SelfBalance opcodes and add gas cost change of trie-dependent-opcodes(eip1884) #958.selfBalance
andchainId
based on the execution time.addmod
,mulmod
,not
,xor
,shl
,shr
,sar
based on the execution time.The computation cost is calculated based on the instructions_test.go benchmark test. Double the average execution time when benchtime is 200x.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...