Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocated shortcut for proposer refresh #1034

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

jeongkyun-oh
Copy link
Contributor

Proposed changes

Refresh method relates to the validators, demotedValidators, and proposers.
The validators and demotedValidators should be updated although the proposers are calculated already, so the refresh proposers short cut logic is moved.

This resolves the problem where the validator is not demoted right after the addvalidator vote.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

yoomee1313
yoomee1313 previously approved these changes Sep 14, 2021
Copy link
Contributor

@yoomee1313 yoomee1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeongkyun-oh jeongkyun-oh merged commit 932f6a5 into klaytn:dev Sep 14, 2021
@jeongkyun-oh jeongkyun-oh deleted the relocate-refresh-shortcut branch September 14, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants