Added eth namespace Block Header apis #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Engine() to backend * We need it when calculating proposer of the block. * Regenerated backend_mock.go also. Add rpcMarshalHeader * This is for supporting Etheruem compatible format. Add Methods for BlockNonce * Added implementations from Ethereum. Make BaseFee as protocol params and make extradata for eth namespace. * Value of BaseFee and Extradata are considered by klaytn developers. * While defining BaseFee as protocol params, the parts that previously defined baseFee were also modified.
Added Engine() to backend * We need it when calculating proposer of the block.
aeharvlee
requested review from
aidan-kwon,
ehnuje,
jeongkyun-oh,
jimni1222,
KimKyungup,
sirano11,
joowon-byun and
yoomee1313
as code owners
ExtraData should be empty which is discussed by Klaytn devs. GasLimit: current ethereum gas limit x 30
jimni1222
reviewed
Jan 3, 2022
GetHeaderByNumber in Ethereum always return nil because the backend returns nil at error position.
aeharvlee
commented
Jan 3, 2022
api/api_ethereum.go
Outdated
Comment on lines
373
to
375
| klaytnHeader, err := api.publicBlockChainAPI.GetHeaderByNumber(ctx, number) | ||
| // In Ethereum, err is always nil because the backend of Ethereum always return nil. | ||
| err = nil |
There was a problem hiding this comment.
It can be looked weird, but currently Ethereum backend always return nil at error position.
Klaytn devs decided to serve this field as empty when serving eth namespace api.
yoomee1313
reviewed
Jan 4, 2022
Co-authored-by: yumiel yoomee1313 <yumiel.ko@krustuniverse.com>
Co-authored-by: yumiel yoomee1313 <yumiel.ko@krustuniverse.com>
yoomee1313
previously approved these changes
Jan 4, 2022
hqjang-pepper
previously approved these changes
Jan 6, 2022
Comment on lines
+64
to
+69
| results := reflect.ValueOf(&api).MethodByName(testAPIName).Call( | ||
| []reflect.Value{ | ||
| reflect.ValueOf(context.Background()), | ||
| reflect.ValueOf(blockParam), | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Reflect package is used due to call multiple api tests at a time
jimni1222
previously approved these changes
Jan 6, 2022
aidan-kwon
reviewed
Jan 10, 2022
aidan-kwon
reviewed
Jan 10, 2022
Inserting error directly is a bad practice. So use another way to handle it. Use logger exactly.
aeharvlee
dismissed stale reviews from jimni1222, hqjang-pepper, and yoomee1313
via
6b574a4
Co-authored-by: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>
jimni1222
previously approved these changes
Jan 10, 2022
All block signatures should be recoverable, and miner is the field Klaytn should provide the correct value. It's not the field dummy value is allowed.
aidan-kwon
reviewed
Jan 12, 2022
Gave values to header so that we can check whether rpcMarshalHeader assigns all fields values properly
Just compare field and values using json marshaling, it is more simpler
jimni1222
approved these changes
Jan 13, 2022
yoomee1313
approved these changes
Jan 14, 2022
sirano11
approved these changes
Jan 14, 2022
9 tasks
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added
Engine()tobackendinterface andCNAPIBackendalso.(&EthereumAPI{}).Minermethod.backend_mock.goalso because new methodEngineis added.Added
rpcMarshalHeaderfunction.Added Methods for
BlockNonceMade
BaseFeeas protocol params for eth namespace.BaseFeeandExtradataare considered by klaytn developers.BaseFeeas protocol params, the parts that previously defined baseFee were also modified.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...