implemented functions to restart abnormally terminated node automatically. #1101
Conversation
sirano11
requested review from
aluminous,
jimni1222,
jeongkyun-oh,
aidan-kwon and
aeharvlee
|
|
|
@sirano11 Im not tested yet, but just worried about duplicating pid files situation (e.g. Running all k*nd series in a machine with same DATA_DIR and autorestart option and then maybe duplication problem happen) So my idea is like below. in in |
build/packaging/linux/bin/kbnd
Outdated
| fi | ||
| AUTO_RESTART_DAEMON_PID_NUM=$(eval "cat $auto_restart_daemon_pidfile") | ||
| if [[ ! -z "$AUTO_RESTART_DAEMON_PID_NUM" ]]; then | ||
| export auto_restart_daemon_pid=$(eval "ps -p $AUTO_RESTART_DAEMON_PID_NUM -o pid=") |
There was a problem hiding this comment.
Is it necessary to use $(eval "cmd...") instead of $(cmd...)?
It seems like this pattern was already in use in other places, but I think $(cmd) should have the same result (capturing output of the command to an environment variable) while being simpler to read and avoiding the use of eval.
There was a problem hiding this comment.
@aluminous
I removed eval. thanks.
sirano11
dismissed stale reviews from jeongkyun-oh, aidan-kwon, aeharvlee, hqjang-pepper, and jimni1222
via
1524f44
yoomee1313
requested review from
aluminous,
jimni1222,
jeongkyun-oh,
hqjang-pepper,
aidan-kwon and
aeharvlee
Proposed changes
This PR implemented functions to restart abnormally terminated node in klaytn node daemon file.(kend, kcnd...)
To restart abnormally terminated node automatically, it need to set
AUTO_RESTART_NODE,AUTO_RESTART_INTERVALin kxxd.conf file.I tested this script in variable environments. Please check the attached log and below log.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...