-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Block related eth namespace APIs #1121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klaytn now supports eth namespace Block related apis Add rpcMarshalBlock * format the block which will be returned to api caller
aeharvlee
requested review from
aidan-kwon,
jeongkyun-oh,
jimni1222,
KimKyungup,
mckim19,
sirano11 and
yoomee1313
as code owners
January 21, 2022 06:41
aeharvlee
changed the title
Implemented Block related APIs
Implemented Block related eth namespace APIs
Jan 21, 2022
jimni1222
reviewed
Jan 21, 2022
Instead of re-defining DummyGasLimit, it will be great to use pre-defined UpperGasLimit in Klaytn.
jimni1222
reviewed
Jan 21, 2022
jimni1222
previously approved these changes
Jan 24, 2022
5 tasks
7 tasks
aidan-kwon
previously approved these changes
Jan 28, 2022
I resolved merge conflicts. |
jimni1222
reviewed
Feb 3, 2022
jimni1222
reviewed
Feb 3, 2022
Co-authored-by: Jamie <32922423+jimni1222@users.noreply.github.com>
jimni1222
approved these changes
Feb 7, 2022
@jeongkyun-oh @yoomee1313 |
aidan-kwon
approved these changes
Feb 7, 2022
yoomee1313
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implemented
eth
namespace Block related apisRelated Confluence: Klaytn, Ethereum data structures comparison
How to test this PR
First, please clone my origin repo.
1. Run added tests in this PR.
go test -run "TestEthereumAPI_GetBlock*" -v ./... -count=1
2. Build ken and test with it.
1. Build ken with source codes related with this PR.
make ken
2. Run ken
eth
namepsace to RPC_API and WS_API in kend.confTest Logs
When using number or hash with fullTxs option as false
KEN
Geth
When using number or hash with fullTxs option as true
KEN
Geth
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...