Implemented eth namespace api newHeads #1127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NewHeads subscribe heads newly created and return it as
Ethereum Header data structure.
To access events which is private field of publicFilterAPI,
I added public getter method
Events()
.How to test this PR
First, please clone my origin repo.
1. Build ken with source codes related with this PR.
make ken
2. Run ken
eth
namepsace to RPC_API and WS_API in kend.confTest Logs
KEN
Beautified Result Sample
Error situation
Unlike Geth, there a point where error can occur before notifying heads.
But it is hard to produce the error during test, so we can test it by generating an error in the code like below.
In that case, the error happen and subscription channel is closed after 5 head arrived with below log.
GETH
Beautified Result Sample
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...