Updated legacy account type to Klaytn account type #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
changed the title
kjhman21
reviewed
Feb 10, 2022
kjhman21
reviewed
Feb 10, 2022
jeongkyun-oh
changed the title
kjhman21
reviewed
Feb 10, 2022
aidan-kwon
reviewed
Feb 11, 2022
snapshot/generate.go
Outdated
Comment on lines
657
to
661
| contractAcc, ok := acc.(*account.SmartContractAccount) | ||
| if !ok { | ||
| accMarker = nil | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Don't we need to call wipeKeyRange for EOA?
There was a problem hiding this comment.
@aidan-kwon Can you check this again?
kjhman21
approved these changes
Feb 11, 2022
aidan-kwon
approved these changes
Feb 11, 2022
|
@KimKyungup @ehnuje PTAL this Snapshot PR. We need one more approve |
yoomee1313
reviewed
Feb 11, 2022
yoomee1313
approved these changes
Feb 11, 2022
Comment on lines
-632
to
-637
| if bytes.Equal(acc.CodeHash, emptyCode[:]) { | ||
| dataLen -= 32 | ||
| } | ||
| if acc.Root == emptyRoot { | ||
| dataLen -= 32 | ||
| } |
There was a problem hiding this comment.
Why did you remove this logic? Is it unnecessary in Klaytn?
There was a problem hiding this comment.
@hqjang-pepper This is for approximate data size. So, Etheruem uses slim account in order to save the space. It reduces dataLen since nil is stored instead of emptyRootHash or emptyCodeHash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
SlimAccounttype which substituteemptyHashandemptyCodeHashtonilvalue. In this PR, theSlimAccountconcept is deleted since we have two different types of Account.account.Accounttype.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)