Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fixed gas price value from tx pool #1211

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

kjhman21
Copy link
Collaborator

@kjhman21 kjhman21 commented Mar 2, 2022

Proposed changes

PROBLEM

  1. We have two conflict. GasPrice() APIs in klay_ namespace (PublicKlayAPI and GovernanceKlayAPI)
  2. PublicKlayAPI returns gasPrice that is set when the process starts.
  3. GovernanceKlayAPI has possibility that it returns wrong value for the last epoch.

SOLUTION

  • Remove GasPrice() from GovernanceKlayAPI.
  • Update GasPrice() in PublicKlayAPI to get the value from txpool.
  • This is draft implementation. We need to check this resolves the issue first.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

instead of using the value at the initialization.
aidan-kwon
aidan-kwon previously approved these changes Mar 3, 2022
@kjhman21 kjhman21 self-assigned this Mar 3, 2022
@kjhman21 kjhman21 changed the title [Draft] Get fixed gas price value from tx pool Get fixed gas price value from tx pool Mar 3, 2022
@kjhman21 kjhman21 merged commit c8d6fb8 into klaytn:dev Mar 4, 2022
@kjhman21 kjhman21 deleted the getGasPriceFromTxPool branch March 4, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants