-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Hard-fork block numbers for v1.8.0 #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
requested review from
KimKyungup,
jeongkyun-oh and
yoomee1313
as code owners
March 10, 2022 04:15
aidan-kwon
force-pushed
the
220310/hardForkBlock
branch
from
March 10, 2022 04:29
7971099
to
8193bf1
Compare
jeongkyun-oh
previously approved these changes
Mar 10, 2022
aidan-kwon
requested review from
jimni1222,
sirano11 and
mckim19
as code owners
March 10, 2022 08:32
jeongkyun-oh
previously approved these changes
Mar 10, 2022
yoomee1313
previously approved these changes
Mar 10, 2022
kjhman21
previously approved these changes
Mar 11, 2022
aidan-kwon
dismissed stale reviews from kjhman21, yoomee1313, and jeongkyun-oh
via
March 11, 2022 02:09
a1d67e8
jeongkyun-oh
approved these changes
Mar 11, 2022
hqjang-pepper
approved these changes
Mar 11, 2022
yoomee1313
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The hard-fork block numbers are calculated estimating 3/24 (Baobab) or 3/31 (Cypress).
Reviewers, please calculate block numbers again for double check.
Baobab
3/10, 10:00:00 (UTC+9): 85304295
3/24, 10:00:00 (UTC+9): 85304295 + 60 * 60 * 24 * 14 = 86513895
Cypress
3/10, 10:00:00 (UTC+9): 85001605
3/31, 10:00:00 (UTC+9): 85001605 + 60 * 60 * 24 * 21 = 86816005
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)