Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Added missing error handling #1265

Merged
merged 3 commits into from Apr 14, 2022
Merged

[Config] Added missing error handling #1265

merged 3 commits into from Apr 14, 2022

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

  • Added missing error handling
  • Fixed no error output when feeding a wrong VERVOSITY value in the configuration file.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

kjhman21
kjhman21 previously approved these changes Mar 24, 2022
KimKyungup
KimKyungup previously approved these changes Mar 30, 2022
henry-will
henry-will previously approved these changes Mar 31, 2022
hqjang-pepper
hqjang-pepper previously approved these changes Apr 7, 2022
log/zap_logger.go Outdated Show resolved Hide resolved
@aidan-kwon aidan-kwon merged commit c5148df into dev Apr 14, 2022
@aidan-kwon aidan-kwon deleted the config-error-check branch April 14, 2022 04:48
aidan-kwon added a commit to aidan-kwon/klaytn that referenced this pull request Apr 19, 2022
[Config] Added missing error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants